add enchantment abbreviations as slot text #1056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (Map.Entry<String, String> entry : ID_ABBREVIATION_MAP.entrySet()) { | ||
| final String put = otherDirection.put(entry.getValue(), entry.getKey()); | ||
| if (put != null) { | ||
| throw new IllegalArgumentException("Duplicate key [%s, %s] for value %s".formatted(put, entry.getKey(), entry.getValue())); |
There was a problem hiding this comment.
No need to throw here, logging an error is sufficient.
There was a problem hiding this comment.
I explicitly decided to throw an exception, since you may not notice a simple log. And since the exception will only be throw in a debug/development environment I assumed it should be fine
There was a problem hiding this comment.
Actually, this would be more sufficient as a unit test. This way we also don't ship test code.
|
will this add to weapons/armors? e.g. for terminator,used to tell if it's SE or duplex |
AzureAaron
requested changes
Dec 5, 2024
| return Text.empty(); | ||
| } | ||
|
|
||
| final int color; |
There was a problem hiding this comment.
replace this with a switch
LifeIsAParadox
added
changes requested
AzureAaron
added
the
merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.