Museum HUD

[7azeemm]

Ideas for future:

• coins to reach next museum milestone
• on button click open recipe/forgeRecipe/sellerLocation(npc) or open lbin item in auction house
• support npc price
• ability to bookmark donation (adds star icon in button? or change bg color to green?)
• compact donations related to each other in one button maybe like garden hoes and necron blades
• more complex XpPerCoin algorithm (as example: no one with fully functionnal brain is going to buy all necron's blade, so if he gets one handle the cost of remaining blades is nearly nothing if he gonna convert them)

[7azeemm]

Optimized tooltip and 'Coins per XP' sorting and more

[AzureAaron]

You should also rebase this on the latest commit to ensure it works on 1.21.4, though I don't think you will need to change anything regarding the new version.

[7azeemm]

is mouseClicked method changed in 1.21.4??
Inventory clicks are not registering although widget clicks are
i spent 2 hours looking at the code and found that if i change the last return value to false return superClicked => return false all works fine. but this doesn't make sense

[Emirlol]

is mouseClicked method changed in 1.21.4??

Screen inherits its mouseClicked method from ParentElement, which now checks the hovered element before calling mouseClicked. Perhaps it has something to do with that?

1.21.4

1.21.3

[7azeemm]

Couldn't find any other clean fix than this.
it should be fine i guess

[7azeemm]

Overlay's dimensions were overlapping with the inventory part, which made the mouse click event being called only for the widget.

[7azeemm]

Btw, The Hypixel API only registers items that a player has donated, excluding any downgraded variants. For example, if a player donates Fermento Armor, its downgraded versions (e.g., Cropie Armor) will not be registered in the API. So i made few adjustments to it. However, these changes require an update to the local data cache. if museum_item_cache.json file exists the player should run /skyblocker museum resync or delete the json file to work properly without any missing donations.

[AzureAaron]

Just the static block thing otherwise the code seems good

[viciscat]

naming nitpicks YAY

(previous comments came back, sorry about that)