ItemList Changes #1119
Merged
ItemList Changes #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces a bunch of changes to the ItemList feature, to hopefully enhance user experience. Most importantly, you can now filter out specific elements in the list to narrow down the results. The lore-search now works properly, and you're now able to use the wiki lookup key in the recipe book. Besides all that, shift-clicking on the recipe result button will suggest the recipe to the player using the `viewrecipe` command, to allow quick super-craft access.
Properly use parentheses in the `(animal)` and `(pest)` flagged entries.
Replaces direct chat command handling with MessageScheduler.
kevinthegreat1
requested changes
Jan 2, 2025
src/main/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/FilterOption.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/FilterOption.java
Outdated
Show resolved
Hide resolved
...ain/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/SkyblockCraftingRecipeResults.java
Outdated
Show resolved
Hide resolved
...ain/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/SkyblockCraftingRecipeResults.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/SkyblockRecipeBookWidget.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/SkyblockRecipeBookWidget.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/utils/render/gui/CyclingTextureWidget.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
Replaced the Identifiable interface with a Supplier-based design for enum, updated related classes to use Supplier methods and refactored filtering logic for consistency. Additionally, added a new tip for viewing recipes in the recipe book, and changed the Shift+Click requirement to a simple right click.
LifeIsAParadox
added
reviews needed
...ain/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/SkyblockCraftingRecipeResults.java
Show resolved
Hide resolved
| var rawID = ItemUtils.getItemId(result.getDisplayStack()); | ||
| if (result.isMouseOver(mouseX, mouseY)) { | ||
| MessageScheduler.INSTANCE.sendMessageAfterCooldown(String.format("/viewrecipe %s", rawID), true); | ||
| return true; |
There was a problem hiding this comment.
Nice catch I overlooked this.
LifeIsAParadox
added
merge me please
AzureAaron
requested changes
Jan 3, 2025
src/main/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/FilterOption.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/FilterOption.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/FilterOption.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I don't think the asserts are necessary
There was a problem hiding this comment.
They just fix all the warning in the IDE
There was a problem hiding this comment.
I think it makes sense to use asserts as "I know this won't be null, now stop giving me warnings."
There was a problem hiding this comment.
I think it makes sense to use asserts as "I know this won't be null, now stop giving me warnings."
Or even with other boolean conditions, such as when the children method returns a list of three, you know for sure its size is going to be 3, so you can assert children().size() == 3 - It's just cleaner than @SurpressWarnings
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
Jan 4, 2025
LifeIsAParadox
added
merge me please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a bunch of changes to the ItemList feature, to hopefully enhance user experience. Most importantly, you can now filter out specific elements in the list to narrow down the results. The lore search now works properly, and you're now able to use the wiki lookup key in the recipe book. Besides all that, shift-clicking on the recipe result button will suggest the recipe to the player using the
viewrecipecommand, to allow quick super-craft access.P.S. The second commit only exists because I forgot to check those files in the first one.