Add "Swing On Abilities" #1127
Open
Add "Swing On Abilities" #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a simple configuration option to enable hand-swing animations for items with right-click abilities.
AzureAaron
requested changes
Jan 7, 2025
src/main/java/de/hysky/skyblocker/config/configs/UIAndVisualsConfig.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Init | ||
| public static void init() { | ||
| UseItemCallback.EVENT.register((player, world, hand) -> { |
There was a problem hiding this comment.
I think it would be a lot safer to mixin and call whatever code is needed to trigger just the animation since this manually sends a packet to the server. It's also means we (and other mods) can use this event to cancel an item use rather than having to mess around with event phases and init prioritization.
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a simple configuration option to enable hand-swing animations for items with right-click abilities.