Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Backpack Preview #387

Merged
merged 9 commits into from
Oct 26, 2023

Conversation

kevinthegreat1
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 commented Oct 26, 2023

Custom texture packs now work with backpack preview!
The title of the container is also shown now.

Closes #351.

Also a lot of cleanup.
Screenshot 2023-10-25 at 21 40 14
Screenshot 2023-10-25 at 21 39 29

@kevinthegreat1 kevinthegreat1 changed the title Refactor Backpack Background Refactor Backpack Preview Oct 26, 2023
@AzureAaron AzureAaron added the reviews needed This PR needs reviews label Oct 26, 2023
AzureAaron
AzureAaron previously approved these changes Oct 26, 2023
@AzureAaron AzureAaron added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Oct 26, 2023
@AzureAaron
Copy link
Collaborator

Wait how does this work with multi account setups on one profile?

@AzureAaron AzureAaron dismissed their stale review October 26, 2023 02:55

questioning something

@kevinthegreat1
Copy link
Collaborator Author

You can do that? I guess I'll go fix it

@AzureAaron
Copy link
Collaborator

You can do that? I guess I'll go fix it

I forgot about my privileges lmfao

@AzureAaron AzureAaron merged commit 0aa9d8b into SkyblockerMod:master Oct 26, 2023
1 check passed
@kevinthegreat1 kevinthegreat1 deleted the backpack-background branch October 26, 2023 04:39
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backpack Preview does not work with custom texture packs and other features
2 participants