Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Fishing Helper Accuracy #837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AzureAaron
Copy link
Collaborator

I've been doing a lot of lava fishing recently and I found that the fishing helper 95% of the time didn't ever play the title notification for some reason. So to fix this the PR adds detection for Hypixel's fishing helper hologram above the bobber and plays the sound when it shows the three exclamation marks in red.

@AzureAaron AzureAaron added the small change Small changes that are easier to review label Jul 12, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 12, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to look into this since fishing helper wasn't designed for lava fishing.

@AzureAaron
Copy link
Collaborator Author

Yeah this isn't that big of a deal to me, just something on my list of things to do

@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts This PR has merge conflicts that need solving. small change Small changes that are easier to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants