Added option to display numbers for commissions #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthegreat1
requested changes
Jul 30, 2024
src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/component/ProgressComponent.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/hud/HudCommsWidget.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
Jul 31, 2024
LifeIsAParadox
added
merge me please
|
This unfortunately conflicts with the hud pr, we'll try to make a decision. |
|
Depends on #816. |
| * @return the actions needed to complete the commission | ||
| */ | ||
| private static int getCommissionMax(String commission) { | ||
| switch (commission) { |
There was a problem hiding this comment.
This could be turned into a switch expression.
LifeIsAParadox
added
the
merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to display numbers for coms in the Dwarven HUD instead of percentages.