feat: use mod API for ping packet #523
Draft
+56
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kinda works, but not very well yet. I pretty much always get "Already pinging!" on manual pings and I seem to be getting FPS drops(?) |
|
So, I've fixed it, but the mod API seems to have a rate limit of 5 seconds on ping packets. This works well enough for the ping display, not sure what to do about manual pings though, probably just defer to the last value if a ping was sent less than 5s ago. |
My-Name-Is-Jeff
force-pushed
the
dev
branch
3 times, most recently
from
5bade78 to
5140177
Compare
|
This seems to be causing occasional crashes, which appear to come from the Hypixel Mod API library, but I'm not 100% sure. I'll investigate further later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from using C16PacketClientStatus to ServerboundPingPacket from the Hypixel Mod API for sending pings.