Check channel agent Id #1347
Merged
Check channel agent Id #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-singh
force-pushed
the
alistair/check-agent-id
branch
from
c236149 to
8b4ad44
Compare
vgeddes
reviewed
Jan 8, 2025
contracts/src/Assets.sol
Outdated
| @@ -280,7 +280,11 @@ library Assets { | |||
| } | |||
|
|
|||
| // @dev Mint foreign token from Polkadot | |||
| function mintForeignToken(bytes32 foreignTokenID, address recipient, uint256 amount) external { | |||
| function mintForeignToken(address agent, bytes32 foreignTokenID, address recipient, uint256 amount) external { | |||
There was a problem hiding this comment.
As discussed before, I prefer if we check the channel id instead of the agent id. Ultimately what we are doing is adding a restriction that the mint message can only be passed via the Channel owned by AssetHub.
Example:
function mintForeignToken(ChannelID channelID, ...) {
if (channelID == $.assetHubParaID.into()) { ... }
}There was a problem hiding this comment.
Addressed in bbf6532
vgeddes
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.