Skip to content

fix(wrapper): correct disable guidance - #1607

Open
John-David Dalton (jdalton) wants to merge 1 commit into
v1.xfrom
fix/wrapper-off-guidance-v1x
Open

John-David Dalton (jdalton) wants to merge 1 commit into
v1.xfrom
fix/wrapper-off-guidance-v1x

Conversation

@jdalton

@jdalton John-David Dalton (jdalton) commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Show users the supported socket wrapper off command after enabling the shell wrapper, so the instructions actually remove the aliases.

Implementation and validation

A real CLI regression enables the wrapper in a temporary home, checks the guidance, and verifies that disabling it removes both aliases.

Validation: build:dist:src, four wrapper unit tests, and scoped lint passed. Full build:dist and check:tsc still report an unrelated TS2339 at src/commands/optimize/update-manifest-by-agent.mts:140.

Automated review notes

[!NOTE]
Low Risk
User-facing copy and test-only changes; no change to wrapper enable/disable behavior beyond fixing incorrect instructions.

Overview
Corrects the post-enable success message so it tells users to run socket wrapper off instead of the non-existent socket wrapper --disable, aligning guidance with the documented on / off subcommands.

Adds an integration test that enables the wrapper in a temporary home, asserts the printed disable hint and shell aliases, then runs wrapper off and confirms both npm and npx aliases are removed from the profile.

Reviewed by Cursor Bugbot for commit 49a9a88. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant