Repository navigation
fix(scan): list socket scan reach in help - #1664
Merged
Merged
Conversation
The reach command was marked hidden, so `socket scan --help` never listed it even though it is a supported command. Unhide it and add it to the help snapshot.
Martin Torp (mtorp)
marked this pull request as ready for review
October 29, 2026 06:48
Martin Torp (mtorp)
requested a review
from Benjamin Barslev Nielsen (barslev)
October 29, 2026 06:48
Benjamin Barslev Nielsen (barslev)
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
socket scan reachwas marked hidden, sosocket scan --helpnever listed it, even though it's a supported command. This unhides it, adds it to the help snapshot test, and notes it in the changelog.The
socket scan reachabilityalias stays hidden, same as themetaalias.Expected reviewer effort: Stamp
Note
Low Risk
Help text and test snapshot only; reach command behavior is unchanged.
Overview
socket scan reachwas registered as a hidden subcommand, sosocket scan --helpnever listed it despite being fully supported. This PR setshiddentofalseon the reach command config so it appears alongside the other scan subcommands.The help snapshot test and CHANGELOG are updated to match. Hidden aliases such as
reachabilityandmetaare unchanged.Reviewed by Cursor Bugbot for commit 3f9d492. Configure here.