Skip to content

Commit

Permalink
Fix typos and style inconsistencies related to configuration (#2580)
Browse files Browse the repository at this point in the history
* Fix 'min' accidentally defined as 'max'

* Remove duplicate retract_lift_above/below definitions

* Add correct unit for jerk

* Make speed tooltip consistent with others

* Remove accidental 's' in Qidi XPlus config

* Remove trailing comma in RatRig config

* Add 'type' field to KP3S PRO configs

* Revert "Make speed tooltip consistent with others"

This reverts commit 16c0575.

* Revert "Remove duplicate retract_lift_above/below definitions"

This reverts commit 54ca51f.

* Remove non-translated retract_lift_above/below definitions

* Update PrintConfig.cpp

Revert jerk unit
  • Loading branch information
r6e authored Nov 3, 2023
1 parent 905d104 commit f1345d2
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 18 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"type": "process",
"compatible_printers": [
"Kingroon KP3S PRO S1 0.4 nozzle"
],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"type": "process",
"compatible_printers": [
"Kingroon KP3S PRO S1 0.4 nozzle"
],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"type": "process",
"compatible_printers": [
"Kingroon KP3S PRO S1 0.4 nozzle"
],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"type": "process",
"compatible_printers": [
"Kingroon KP3S PRO V2 0.4 nozzle"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@
"compatible_printers": [
"Qidi X-Plus 3 0.6 nozzle"
]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"gap_infill_speed": "100",
"travel_speed": "350",
"compatible_printers": [
"RatRig V-Core 3 500 0.4 nozzle",
"RatRig V-Core 3 500 0.4 nozzle"
]
}
17 changes: 1 addition & 16 deletions src/libslic3r/PrintConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ void PrintConfigDef::init_fff_params()
def->tooltip = L("Bed temperature of the initial layer. "
"Value 0 means the filament does not support to print on the Textured PEI Plate");
def->sidetext = L("°C");
def->max = 0;
def->min = 0;
def->max = 300;
def->set_default_value(new ConfigOptionInts{45});

Expand Down Expand Up @@ -3043,21 +3043,6 @@ def = this->add("filament_loading_speed", coFloats);
def->mode = comSimple;
def->set_default_value(new ConfigOptionFloats { 0.4 });

def = this->add("retract_lift_above", coFloats);
def->label = L("Z hop lower boundary");
def->tooltip = L("Z hop will only come into effect when Z is above this value and is below the parameter: \"Z hop upper boundary\"");
def->sidetext = L("mm");
def->mode = comAdvanced;
def->set_default_value(new ConfigOptionFloats{0.});

def = this->add("retract_lift_below", coFloats);
def->label = L("Z hop upper boundary");
def->tooltip = L("If this value is positive, Z hop will only come into effect when Z is above the parameter: \"Z hop lower boundary\" and is below this value");
def->sidetext = L("mm");
def->mode = comAdvanced;
def->set_default_value(new ConfigOptionFloats{0.});


def = this->add("z_hop_types", coEnums);
def->label = L("Z hop type");
def->tooltip = L("Z hop type");
Expand Down

0 comments on commit f1345d2

Please sign in to comment.