Thumbnail Formats Option Ported from PrusaSlicer and add BIQU/BTT format #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocraftyone
force-pushed
the
patch-thumbnail-options
branch
from
79c6ff5 to
b14aacc
Compare
|
@sarvenn THANK YOU! @Ocraftyone |
SoftFever
reviewed
Oct 14, 2023
SoftFever
reviewed
Oct 14, 2023
SoftFever
reviewed
Oct 14, 2023
|
@Ocraftyone I renamed BIQU to BTT_TFT for better clarity in 6edf66e Let me know whether the changes look good for you |
|
@SoftFever |
use \r\n for new lines in the biqu thumbnail portion. the firmware requires these end characters to function properly. update names of variables and add comments to be more descriptive replace modified Qt pixel algorithm with much simpler algorithm from BTT TFT firmware
Ocraftyone
force-pushed
the
patch-thumbnail-options
branch
from
6edf66e to
ba74a65
Compare
Closed
|
ok. i made the change. just changed the drop down option to remove the underscore between BTT and TFT |
|
just checked and everything else seems to be working as expected 👍 |
SoftFever
approved these changes
Oct 17, 2023
|
Thank you 👍 |
|
@Ocraftyone Unfortunately, I noticed that the thumbnails generated with the method you implemented leaves the objects outline jagged (as if the transparency was missing). Do you know what could be causing this? Here is a screenshot of a side by side comparison. on the left: your implementation
Here are the corresponding code-blocks: your implementationpython script: |
|
Is this on the latest beta build? |
|
It is this build: https://github.com/SoftFever/OrcaSlicer/actions/runs/6546865673 |
|
and did you notice this issue while we were running tests in the issue discussion? if not, I may need to move back to the Qt algorithm. The algorithm I am currently using is what the tft display uses when converting png encoded thumbnails to native on display. |
|
Have you seen the python script that produces the output we need?
Now I remember! #1894 (comment)There were no such issues, as only the end of line was different! |
|
are you able to show a picture with the differences shown on the tft |
|
Here you go:
|
|
ok. after a bit of a headache of trying to see if there was any way to improve my version and trying to understand what qt's algorithm does, it seems that whatever calculation they are doing with bitwise is just more accurate that the standard way of converting. I can't even find anyone talking about the way they are doing this conversion. Either way, I am opening a pull request to merge those changes. |
|
So is this affected by the RGBA thing you mentioned in the measure tool PR? |
|
Nope. Completely separate. I'm going to try to get you a build and see if it works as expected. |
|
Are you sure you meant to @ me? :) Not sure how I can help. |
|
Ops ... Sorry! 😅 |
|
:D It's totall fine, just wondered if your question is somehow related to me having added png decoding option for the to the BTT TFTs a while back, because thats the only thing that I can think of ;) Maybe I didn't get it from browsing the messages here, can I acually help somehow? |
|
I'm not in the know about the code, but trying to help to find those who could potentially know what is not working out. Or, as just found out, @CyberDeck might be willing to help as he implemented the base64 thing into BTT TFT. |
|
does the same issue you showed in the picture persist if you use the BTT TFT built in decode? |
|
Sorry, what do you mean by decode? Or what exactly should I do to reproduce what you are asking for? |
|
@Ocraftyone |
|
Thanks for reminding! I was working on getting GH actions working on my repo. Here are the artifacts from the run. https://github.com/Ocraftyone/OrcaSlicer/actions/runs/6593634075 |
|
Good morning,
Thank you for seeing it that way! 😊 Unfortunately still not fixed:
|
|
This is the build right before it was merged. https://github.com/SoftFever/OrcaSlicer/actions/runs/6534955943 |
|
Nope, this doesn't work either. |
|
Do you get different results if you use the other script in that repo? I was going off the one without p24 |
|
The one with p24 is the latest and that is the one I use. |
|
Can you try with the old script and see if you get the correct result?
|
|
I'm right on it. 😊 |
|
Unfortunately this old script is not compatible. This is the error it results in: |
|
Export the gcode then run the script on it manually |
|
Ok, did what you said and it produced what we need. |
|
Okay. I'll have to find more time to mess with it.
|
|
Thank you! |
|
Good afternoon @Ocraftyone, thanks in advance |
|
@Ocraftyone thanks in advance |
|
Any news yet? |
|
@Ocraftyone thanks in advance |
|
@Ocraftyone |
|
@Ocraftyone thanks in advance |
|
@Ocraftyone At this point, you probably hate me for constantly bothering you, but I can't find a solution to this problem myself, so you are the only one I know who is definitely capable of solving this. Please don't be mad at me. If you are done with it and do not intend to deal with matter in the future, please just let me know and I will certainly not bother you with this topic again. Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First major change is adding the option for thumbnail format under the thumbnail size option. The options ported from PrusaSlicer are PNJ, PJG, and QOI.
Second major change is the addition of the BIQU, or BigTreeTech, image format that is used on their TFTs. Doing this also required a small change to the GCodeProcessor.post_process method that passes through the existing end of line characters
fixes #1894