Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid nozzle_type undefined for 'Anycubic Kobra 2 0.4 nozzle' system machine #5159

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

krissrex
Copy link
Contributor

@krissrex krissrex commented Apr 26, 2024

The correct value is undefine.

Related to a comment in #3991 (comment)

Description

Filament loading will crash if this value is undefined instead of undefine.

Screenshots/Recordings/Graphs

[error]	2024-04-26 19:34:05.440249[Thread 0x00003784]:Slic3r::ConfigBase::load_from_json: parse C:\Users\Kristian\AppData\Roaming\OrcaSlicer\system/Anycubic/machine/Anycubic Kobra 2 0.4 nozzle.json got a generic exception, reason = Invalid value provided for parameter nozzle_type: undefined
[error]	2024-04-26 19:34:05.440249[Thread 0x00003784]:Slic3r::PresetBundle::load_vendor_configs_from_json::<lambda_2e6da75a0232aea84d16ba067e6fa242>::operator (): load config file C:\Users\Kristian\AppData\Roaming\OrcaSlicer\system/Anycubic/machine/Anycubic Kobra 2 0.4 nozzle.json Failed!
[error]	2024-04-26 19:34:05.440249[Thread 0x00003784]:Slic3r::PresetBundle::load_vendor_configs_from_json, got error when parse printer setting from C:\Users\Kristian\AppData\Roaming\OrcaSlicer\system/Anycubic/machine/Anycubic Kobra 2 0.4 nozzle.json

Tests

Edited the file on my machine directly. It works.

The correct value is undefine.

Related to a comment in SoftFever#3991
@krissrex krissrex changed the title Fix invalid nozzle_type undefined for Anycubic Kobra 2 0.4 nozzle system machine Fix invalid nozzle_type undefined for 'Anycubic Kobra 2 0.4 nozzle' system machine Apr 26, 2024
@krissrex
Copy link
Contributor Author

Note that I do not think this solves 3991. I just discovered the same symptoms, and started my troubleshooting there.
The provided logs of 3991 do not contain the same error as mine.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever
Copy link
Owner

Note that I do not think this solves 3991. I just discovered the same symptoms, and started my troubleshooting there. The provided logs of 3991 do not contain the same error as mine.

Noted.
Thanks for the fix!

@SoftFever SoftFever merged commit f10df34 into SoftFever:main Apr 29, 2024
1 check passed
@krissrex krissrex deleted the fix/kobra-nozzle-type branch May 6, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants