Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0502 5M series start gcode /G3U filament management /AD3 path naming #5232

Closed
wants to merge 0 commits into from

Conversation

FlashforgeOfficial
Copy link
Contributor

Description

1、The start gcode for 5M and 5M pro @0.4mm and @0.6mm nozzle is updated : E -0.2;
2、 For the filaments that only belong to G3U, the AD5M series are now removed from the compatible printer list.
3、 Consolidated the file naming of filaments in form: “Flashforge Generic XXX @ff AD3”.
Details are in the screenshots.

Screenshots/Recordings/Graphs

1
2
3
4
5

Tests

Tests work fine for me.
I changed the other Vendor profiles by mistake, but then recovered them from main branch profile, but the commit still showing those files.

Please let me know how to submit a cleaner PR for changes with Flashforge changes only if needed.

For your review @SoftFever @RikshaDriver .

@FlashforgeOfficial
Copy link
Contributor Author

@RikshaDriver Hi I tried to rename the filaments to look cleaner. But there is a check failure in this PR, saying some issues with the parent path or file inheritance. I re-check the profiles but could not find any clues. Could you help take a look?

@RikshaDriver
Copy link
Contributor

@FlashforgeOfficial @FlashForge in the future you can use the git reset --hard <commit> command to undo previous incorrect commits.

Can have a look at renamed files once you push from new repo.

Suggest removing "Generic" name from filament to streamline everything

@Bai825
Copy link
Contributor

Bai825 commented May 14, 2024

@FlashforgeOfficial @FlashForge in the future you can use the git reset --hard <commit> command to undo previous incorrect commits.

Can have a look at renamed files once you push from new repo.

Suggest removing "Generic" name from filament to streamline everything

Thanks for the tips!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants