Skip to content

CLP-1044: Use common slack notification action - #6245

Merged
mary-georgiou merged 2 commits into
masterfrom
chore/mary-georgiou/CLP-1044-common-slack-notify
Oct 1, 2026
Merged

mary-georgiou merged 2 commits into
masterfrom
chore/mary-georgiou/CLP-1044-common-slack-notify

Conversation

@mary-georgiou

@mary-georgiou mary-georgiou commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

CLP-1044: adopts the shared slack-notify composite action (part of the CLP-894 rollout).

Adds a notify-build-failure job to build.yml that posts to Slack when the build/QA pipeline fails on master, branch-*, or dogfood-*, replacing the previous check_suite-based draft (that trigger never fires for GitHub Actions' own check suites, so the job must live inside the workflow it monitors).

This repo had no prior CI-failure Slack notification, so channel squad-corelang-notifs and branch-patterns: 'master,branch-*,dogfood-*' were chosen to match the repo's actual protected-branch/push triggers in build.yml.

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

CLP-1044

Comment thread .github/workflows/slack-notify.yml Outdated
Adds a notify-build-failure job to build.yml that reports pipeline
failures on protected branches via the shared
SonarSource/core-languages-tooling-public/common-actions/slack-notify
action, replacing the stale check_suite-based approach with an
in-workflow job as required by the action's current interface.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@mary-georgiou
mary-georgiou force-pushed the chore/mary-georgiou/CLP-1044-common-slack-notify branch from 3a9bd77 to 54b84ac Compare September 30, 2026 11:30
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@gitar-bot

gitar-bot Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved 1 closed / 1 findings

🔴 High risk · The new notification job gains OIDC token issuance permission.

Adopts the shared slack-notify composite action to post build failures to Slack on master, branch-*, and dogfood-* branches. Replaces the previous check_suite-based approach, which never fired for GitHub Actions' own check suites, ensuring notifications are now reliably sent when the build/QA pipeline fails.

✅ 1 closed
✅ Bug: check_suite never fires for GitHub Actions CI, so no alert is ever sent

📄 .github/workflows/slack-notify.yml:3-5 📄 .github/workflows/slack-notify.yml:20-21
This repo's CI runs entirely on GitHub Actions (build.yml), and there is no Cirrus or other external CI config. GitHub documents that the check_suite event "does not trigger workflows if the check suite was created by GitHub Actions or if the check suite's head SHA is associated with GitHub Actions" (this prevents recursive workflows). So when a Build run on master fails, this workflow never starts and nothing gets posted to Slack, which defeats the point of the PR. To fix it, trigger on workflow_run for the Build workflow and read the branch and conclusion from github.event.workflow_run. ReleasabilityCheck.yml already uses workflow_run this way.

Review coverage

🧪 Functional validation 3 of 3 objectives covered

📋 Rules No rules evaluated

🤖 Auto-approval Not enabled · Set up

Implementation Status ✅ 3 of 3 objectives covered
✅ CLP-1044 - 3 of 3 objectives covered

This PR covers adding a CI workflow triggered on check_suite that calls the shared slack notification action to report failures to the #squad-corelang-notifs channel.

✅ 3 covered here
  • ✅ Add a CI workflow triggered on check_suite
  • ✅ Call the shared slack notification action on master CI failures
  • ✅ Report failures to the #squad-corelang-notifs channel
Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown
Contributor

@mary-georgiou
mary-georgiou marked this pull request as ready for review September 30, 2026 15:10

@aurelien-coet-sonarsource aurelien-coet-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mary-georgiou
mary-georgiou merged commit 6a71c4c into master Oct 1, 2026
18 checks passed
@mary-georgiou
mary-georgiou deleted the chore/mary-georgiou/CLP-1044-common-slack-notify branch October 1, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants