Skip to content

SONARJAVA-7095 Use a common model for Spring context gathering - #6282

Open
aurelien-coet-sonarsource wants to merge 2 commits into
masterfrom
ac/SONARJAVA-7095
Open

aurelien-coet-sonarsource wants to merge 2 commits into
masterfrom
ac/SONARJAVA-7095

Conversation

@aurelien-coet-sonarsource

@aurelien-coet-sonarsource aurelien-coet-sonarsource commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary by Gitar

  • Spring context gathering:
    • Added SpringContextGatheringModel to centralize per-file Spring context data collection
    • Updated BeanDefinitionGatherer and ComponentScanPackageGatherer to use the shared gathering model

This will update automatically on new commits.

@aurelien-coet-sonarsource aurelien-coet-sonarsource changed the title Use a serializable model for Spring context gathering SONARJAVA-7095 Use a serializable model for Spring context gathering Oct 1, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

SONARJAVA-7095

@aurelien-coet-sonarsource aurelien-coet-sonarsource changed the title SONARJAVA-7095 Use a serializable model for Spring context gathering SONARJAVA-7095 Use a common model for Spring context gathering Oct 1, 2026
@aurelien-coet-sonarsource
aurelien-coet-sonarsource added this pull request to stack #6284 October 1, 2026 11:38
@aurelien-coet-sonarsource
aurelien-coet-sonarsource force-pushed the ac/SONARJAVA-7095 branch 2 times, most recently from 3b81fee to e92203f Compare October 1, 2026 12:50
@aurelien-coet-sonarsource
aurelien-coet-sonarsource marked this pull request as ready for review October 1, 2026 13:24
@aurelien-coet-sonarsource
aurelien-coet-sonarsource force-pushed the ac/SONARJAVA-7095 branch 4 times, most recently from 4231b69 to f4913ce Compare October 5, 2026 06:39
@sonarqube-next

sonarqube-next Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@gitar-bot

gitar-bot Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
CI failed: CI build failed due to an external infrastructure error (HTTP 503 Service Unavailable) when querying the Sonar server version during the SonarQube Maven plugin execution.

Overview

1 total log analyzed with 1 infrastructure failure pattern found. The build failed due to an external service availability issue, which is entirely unrelated to the code changes in this pull request.

Failures

Sonar Server Unavailable (confidence: high)

  • Type: infrastructure
  • Affected jobs: 111742805288
  • Related to change: no
  • Root cause: The Maven build failed during the sonar:sonar goal because the server returned an HTTP 503 Service Unavailable error when querying api/server/version.
  • Suggested fix: Retry the CI build once the external Sonar service is healthy and available.

Summary

  • Change-related failures: 0
  • Infrastructure/flaky failures: 1 infrastructure failure due to SonarQube server downtime (HTTP 503).
  • Recommended action: Re-run the CI job once the server is back online.
Code Review ✅ Approved

🟡 Medium risk · Centralizes per-file Spring context collection, changing data aggregation across modules

Refactors Spring context gathering to use a centralized, serializable per-file model. No issues found.

Review coverage

🧪 Functional validation 0 of 2 objectives covered

📋 Rules No rules evaluated

Cross-repo coverage 5 repositories selected

🤖 Auto-approval Not enabled · Set up

Implementation Status ◻️ 0 of 2 objectives covered
◻️ SONARJAVA-7095 - 0 of 2 objectives covered

This PR uses a centralized per-file Spring context model in gatherers, while serialization and de-serialization are handled in subsequent PRs.

Other objectives on this issue, possibly covered elsewhere:

  • ◻️ Implement on-disk serialization for the Spring context model
  • ◻️ Implement de-serialization for the Spring context model

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@datadog-sonarsource

datadog-sonarsource Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

Build | Test Analyze

View more details · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2cbd51e | Docs | View more details | Give us feedback!

@asya-vorobeva asya-vorobeva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants