Add error handling for EDU code #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromehue
force-pushed
the
edu-error-handling
branch
from
268382e to
2a4dc26
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 81.69% 86.73% +5.03%
==========================================
Files 16 17 +1
Lines 448 490 +42
==========================================
+ Hits 366 425 +59
+ Misses 82 65 -17 ☔ View full report in Codecov by Sentry. |
jeromehue
force-pushed
the
edu-error-handling
branch
2 times, most recently
from
0054e7a to
c809ec2
Compare
jeromehue
force-pushed
the
edu-error-handling
branch
from
c809ec2 to
a33bfef
Compare
PatrickKa
requested changes
Dec 10, 2023
PatrickKa
changed the title
jeromehue
force-pushed
the
edu-error-handling
branch
from
3310f0c to
edebf31
Compare
PatrickKa
approved these changes
Dec 17, 2023
Remove edu::ErrorCode::success/successEof/noErrorCodeSet and modify related files accordingly, sometimes by getting rid of do-while loops.
- Add missing #includes - Add missing blank lines - Improve comments and remove wrong ones - Use east const - ...
- Use OUTCOME_TRY() whenever possible - Fix two bugs introduced by using the Outcome library - Make some stylistic changes
PatrickKa
force-pushed
the
edu-error-handling
branch
from
d70bce3 to
976df89
Compare
PatrickKa
force-pushed
the
edu-error-handling
branch
from
976df89 to
19d4d65
Compare
PatrickKa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the Experimental Outcome library to implement proper error handling in EDU component.
Fixes #182