Skip to content

fix(ci): allow release automation to push changes - #533

Merged
dancormier merged 1 commit into
mainfrom
dcormier/fix-release-permissions
Sep 24, 2026
Merged

dancormier merged 1 commit into
mainfrom
dcormier/fix-release-permissions

Conversation

@dancormier

Copy link
Copy Markdown
Contributor

Summary

Fix the release-branch push failure following #519. The release job needs
contents: write to push the Changesets release branch. The workflow-wide
default remains read-only.

Failed run: https://github.com/StackExchange/Stacks-Editor/actions/runs/36044234546/job/107784922442

Changes

  • Grant contents write permission only to the main-only release job.
  • Update the release-configuration assertion to require this permission.
  • Leave release gates, credentials, package versions, and dependencies unchanged.
    No changeset is needed for this CI-only fix.

How to test

  1. Install dependencies with npm ci. Local verification used Node 26.5.0
    and npm 11.17.0; CI uses Node LTS.
  2. Run npm run test:release-config: all six tests pass. The updated assertion
    was also verified to fail against the original read-only release job.
  3. Run npm run lint and ./node_modules/.bin/tsc --noEmit: both pass.
    Lint reports two warnings in unchanged stack-snippets tests.
  4. After merging, confirm the main-branch release job can push
    changeset-release/main and open the separate 1.0.0 release PR.
    This remote behavior remains unverified; the release job is skipped on PRs.

Full unit, browser, and package-consumer suites were not rerun locally for
this permissions-only change; the existing CI gates remain in place.
No UI changes or manual preview activation are needed.

@changeset-bot

changeset-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 04ddcec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets
Name Type
@stackoverflow/stacks-editor Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Sep 24, 2026

Copy link
Copy Markdown

✅ Deploy Preview for stacks-editor ready!

Name Link
🔨 Latest commit 04ddcec
🔍 Latest deploy log https://app.netlify.com/projects/stacks-editor/deploys/6ab57480081c670008b607d8
😎 Deploy Preview https://deploy-preview-533--stacks-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@dancormier
dancormier marked this pull request as ready for review September 24, 2026 19:06
@dancormier
dancormier requested a review from a team as a code owner September 24, 2026 19:06
@dancormier
dancormier merged commit 56a9147 into main Sep 24, 2026
11 checks passed
@dancormier
dancormier deleted the dcormier/fix-release-permissions branch September 24, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant