Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swift Language mode for UITest targets #20

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 12, 2024

Fix Swift Language mode for UITest targets

♻️ Current situation & Problem

Even though #19 enabled Swift 6 Language Mode on the project wide build settings for the UITest project, all the individual targets had a manual override specifying Swift 5. This was fixed by this PR making sure Swift 6 is enabled by default for all targets.

⚙️ Release Notes

  • Fixed Swift 6 Language Mode for UITest targets.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg!

Seems like the only thing we need to change would be the Apple Watch model as this was updated in the runners.

@Supereg Supereg enabled auto-merge (squash) November 20, 2024 08:04
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d9fedae) to head (1ba8afa).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            4         4           
=========================================
  Hits             4         4           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9fedae...1ba8afa. Read the comment docs.

---- 🚨 Try these New Features:

@Supereg Supereg merged commit 117e8d5 into main Nov 20, 2024
15 checks passed
@Supereg Supereg deleted the fix/ui-test-swift-6 branch November 20, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants