-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build-android] Create template for build-android #5
base: master
Are you sure you want to change the base?
Conversation
…eabi-v7a, build icu 55.1
Update icu tar to match one referenced in build script
Changed default NDK version from 4.8 to 4.9
Seems like `RELEASE.TXT` is gone, so `arch` is now used to determine if we're running on 64bit or not. I'm unsure how to properly check for this on Windows, though.
Fix for Android NDK r11c
`android-ndk-r12/sources/android/support/Android.mk` now conditionally compiles based on the `LIBCXX_FORCE_REBUILD` environment variable. Add the variable to our `build.sh` invocation in order to ensure we actually build the stuff we need.
Android NDK r13 appears to have removed a level of nesting within LLVM libc++. The "libcxx" subdirectory no longer exists.
Resolve ICU soname issue
These patches _should_ be able to be applied using `patch`, they automate the changeset currently described at apple/swift/docs/Android.md
I think this is ready to go, I'm going to validate that this script works by running through the instructions on apple/swift/docs/Android.md @modocache: I'll add you as a reviewer after I've validated this change myself |
Please do, thanks! |
It's been a while since I touched this, and unfortunately that error message doesn't really resemble anything I remember. Maybe grep for |
The fork was updated to support newer versions of the NDK, so we should definitely rebase because the instructions over at swift say to use the latest version and that isn't working. I'm going to retry the build using ndk 14r to see if that works instead. I can also try the rebase, but I'm not familiar with either set of changes -- not pelya's nor ours. I'll ping you if I need help |
It looks like our code is out of date, pelya's @modocache do you remember why these changes were made, and would you be able to do a rebase? Or should I check with the author of 1cf9131? |
Yeah, @zhuowei might know! |
@modocache @AndrewSB I think that the cflags were changed because Pelya's version used GNU libstdc++ as stl; it looks like they switched to LLVM libstdc++, so you can just use their version. |
No description provided.