Swivel v3: ExchangeRate Adapters, Protocol Enum, Custom Errors #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework vaulttracker to be able to utilize an adapter to get cToken rate. Remove interfaces Add CERC20 abstract Add Compound & Rari libraries Add Compound & Rari adapters Add InterestRateModel & FixedPointMath Libs Rework Codebase to use adapters rather than directly reading from CErc20
|
Added adapters for:
|
- add adapters mapping - add setAdapters method
|
Added Mint/Burn (Deposit/Withdraw) functionality for all custodial functions in Swivel.sol across:
🔥 🎉 🎈 |
|
Adressing #191 Custom Error Messages Added custom errors across:
Cleaned current reverts across:
|
JTraversa
changed the title
JTraversa
changed the title
JTraversa
changed the title
JTraversa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #190
Further, this is the largest step towards swivel v3 and completes the integration of:
Using this rough design, we can create our own adapters or libraries for aave and yearn and simply chose the correct adapter when deploying a market / the vault
Rework vaulttracker to be able to utilize an adapter to get cToken rate.
Remove interfaces
Add CERC20 abstract
Add Compound & Rari libraries
Add Compound & Rari adapters
Add InterestRateModel & FixedPointMath Libs
Rework Codebase to use adapters rather than directly reading from CErc20