-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gameloop: Split round and time #1710
Conversation
First tests seem to be working as expected on my end. |
yeah, we should probably extend the parenting system to dropdown menus as well. It would be a bit more complex through |
Yeah.. I looked at the vgui stuff cause I wanted to know how that works.. Then I said "nope" and went on with just this PR.. |
Not really able to give a full overview of it in this video, but you at least see the settings and the change in the Scoreboard: 2025-01-06.13-04-11.mp4Everything else I was able to test was successful.. A MapVote always triggered at the right moment (only testet with PAM though). |
Looks good to me, I'd replace "mapvote" with "map change", since the vote is only there with map vote addons. Also just replace "TTT(2)" with TTT2 imho. |
Yeahh after I wrote it I was pretty sure somebody will tell me to change that :P |
Should be good now.. Also: Will add a changelog now as I forgot that... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will tackle #1707
Not finished yet, still have to do all LANG files and some testing + cleanup if neccessarry.
Would love some input on this though!
Only "real" problem I have so far is the settings in the F1 menu: I can not "disable" the round time or the round count setting because the "master" is never null but always a value.. Should not really be confusing though.