Markervision fix: Fixed registry table being able to have duplicates #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saibotk
approved these changes
Jan 6, 2025
|
That's a smart change! While it was intentional the way I did it, I do like your change. We will merge it as soon as you add yourself to the changelog. |
|
Sorry, there we go 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that when new marker vision objects are made with
markerVision.Add, it doesn't clear out existing versions of the same object (matching ent and indentifier). This leads to themarkerVision.registrytable being filled up with objects that do not clear themselves, and makesmarkerVision.Getpotentially return obsolete markers (mainly observed serverside).This PR resolves this possible bloat issue in the registry. This also fixes an issue where marker vision objects can incorrectly change to being visible to team or visible to role (clientside), when it's supposed to be visible to everyone.