Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markervision fix: Fixed registry table being able to have duplicates #1712

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Markervision fix: Fixed registry table being able to have duplicates #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ad2cab
Markervision: Fixed serverside registry table being able to have dupl…
TW1STaL1CKY Jan 6, 2025
b9ff72c
Updated changelog
TW1STaL1CKY Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ All notable changes to TTT2 will be documented here. Inspired by [keep a changel
- Fixed corpse searching sound playing when searched by a spectator, searched covertly, or searched long range (by @TW1STaL1CKY)
- Fixed the mute button in the scoreboard not working (by @TW1STaL1CKY)
- Fixed a few errors in shop error messages (by @Histalek)
- Fixed `markerVision`'s registry table being able to contain duplicate obsolete entries, thus fixing potential syncing issues with markers (by @TW1STaL1CKY)

### Changed

Expand Down
6 changes: 6 additions & 0 deletions lua/ttt2/libraries/marker_vision.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ markerVision.focussedMarkers = {}
-- @return MARKER_VISION_ELEMENT The marker vision object that was created
-- @realm shared
function markerVision.Add(ent, identifier)
local _, index = markerVision.Get(ent, identifier)

if index ~= -1 then
table.remove(markerVision.registry, index)
end

local mvObject = table.Copy(MARKER_VISION_ELEMENT)
mvObject:SetEnt(ent)
mvObject:SetIdentifier(identifier)
Expand Down
Loading