fix({eslint,oxlint}-config): align 'import/order' with 'sortImports' and enforce 'spaced-comment' in Oxlint

.changeset/align-lint-and-format-configs.md

@@ -0,0 +1,9 @@
+---
+'@tanstack/eslint-config': minor
+'@tanstack/oxlint-config': minor
+---
+
+Align the shared configs with each other:
+
+- `@tanstack/eslint-config`: classify `~/`, `@/` and `#` imports as internal in `import/order`, matching the `internalPattern` used by the `sortImports` of `@tanstack/oxfmt-config`
+- `@tanstack/oxlint-config`: enforce `@stylistic/spaced-comment` from `@tanstack/eslint-config`, which Oxfmt does not handle

packages/eslint-config/src/import.ts

@@ -1,5 +1,13 @@
 import type { Linter } from 'eslint'
 
+/**
+ * Classifies the same import prefixes as internal as the `internalPattern` of
+ * `@tanstack/oxfmt-config`, so `import/order` agrees with its `sortImports`
+ */
+export const importSettings: Linter.Config['settings'] = {
+  'import-x/internal-regex': '^(~/|@/|#)',
+}
+
 /**
  * @see https://github.com/un-ts/eslint-plugin-import-x
  */

packages/eslint-config/src/index.ts

@@ -4,7 +4,7 @@ import nodePlugin from 'eslint-plugin-n'
 import globals from 'globals'
 import tseslint from 'typescript-eslint'
 import vueParser from 'vue-eslint-parser'
-import { importRules } from './import.js'
+import { importRules, importSettings } from './import.js'
 import { javascriptRules } from './javascript.js'
 import { nodeRules } from './node.js'
 import { stylisticRules } from './stylistic.js'
@@ -57,6 +57,7 @@ export const tanstackConfig: Array<Linter.Config> = [
       },
     },
     plugins: jsPlugins,
+    settings: importSettings,
     rules: jsRules,
   },
   {
@@ -76,6 +77,7 @@ export const tanstackConfig: Array<Linter.Config> = [
       },
     },
     plugins: jsPlugins,
+    settings: importSettings,
     rules: jsRules,
   },
 ]

packages/oxlint-config/package.json

@@ -43,7 +43,8 @@
     "node": "^20.19.0 || >=22.12.0"
   },
   "dependencies": {
-    "@oxlint/plugins": "catalog:"
+    "@oxlint/plugins": "catalog:",
+    "@stylistic/eslint-plugin": "catalog:"
   },
   "devDependencies": {
     "oxlint": "catalog:",

packages/oxlint-config/src/index.ts

@@ -3,6 +3,7 @@ import { defineConfig } from 'oxlint'
 import { importRules } from './import.ts'
 import { javascriptRules } from './javascript.ts'
 import { nodeRules } from './node.ts'
+import { stylisticRules } from './stylistic.ts'
 import { typescriptRules } from './typescript.ts'
 import type { OxlintConfig } from 'oxlint'
 
@@ -25,6 +26,7 @@ export const tanstackConfig: TanstackConfig = defineConfig({
   plugins: ['import', 'typescript', 'unicorn'],
   jsPlugins: [
     { name: 'tanstack', specifier: resolve('@tanstack/oxlint-config/plugin') },
+    resolve('@stylistic/eslint-plugin'),
   ],
   categories: {
     correctness: 'off',
@@ -50,7 +52,14 @@ export const tanstackConfig: TanstackConfig = defineConfig({
     ...typescriptRules,
     ...importRules,
     ...nodeRules,
+    ...stylisticRules,
   },
 })
 
-export { javascriptRules, importRules, typescriptRules, nodeRules }
+export {
+  javascriptRules,
+  importRules,
+  typescriptRules,
+  nodeRules,
+  stylisticRules,
+}

packages/oxlint-config/src/stylistic.ts

@@ -0,0 +1,12 @@
+import type { DummyRuleMap } from 'oxlint'
+
+/**
+ * Port of `stylisticRules` from `@tanstack/eslint-config`. Oxfmt does not
+ * change comment spacing, so this rule is still enforced by the linter.
+ *
+ * @see https://eslint.style/rules/spaced-comment
+ */
+export const stylisticRules: DummyRuleMap = {
+  /** Enforce consistency of spacing after the start of a comment */
+  '@stylistic/spaced-comment': 'error',
+}