test(solid-query/useInfiniteQuery): match the 'skipToken' test timer advances to the 'queryFn' sleep of 10ms by sukvvon · Pull Request #12305 · TanStack/query

sukvvon · 2026-10-23T16:43:15Z

🎯 Changes

In the should not fetch when queryFn is skipToken, and fetch once it is replaced test, change both advanceTimersByTimeAsync(11) calls to 10, the duration of the queryFn's sleep(10).

solid-query applies the query result directly in its subscription, so the extra 1ms is not needed. With 9, the test fails. This matches the same test in svelte-query, vue-query, and lit-query.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Updated timing in automated coverage for skipped queries, with checks now occurring after 10 ms instead of 11 ms.
- This is a test-only change; it does not alter user-facing behavior or public APIs.

…advances to the 'queryFn' sleep of 10ms

changeset-bot · 2026-10-23T16:43:21Z

⚠️ No Changeset found

Latest commit: 7a54e8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-23T16:43:42Z

View your CI Pipeline Execution ↗ for commit 7a54e8c

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 50s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	5s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 16:48:17 UTC

github-actions · 2026-10-23T16:44:08Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 23 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/vue-query`	5.104.5 → 5.104.6	Changeset
`@tanstack/angular-query-experimental`	5.104.5 → 5.104.6	Dependent
`@tanstack/eslint-plugin-query`	5.104.5 → 5.104.6	Dependent
`@tanstack/lit-query`	0.2.30 → 0.2.31	Dependent
`@tanstack/preact-query`	5.104.5 → 5.104.6	Dependent
`@tanstack/preact-query-devtools`	5.104.5 → 5.104.6	Dependent
`@tanstack/preact-query-persist-client`	5.104.5 → 5.104.6	Dependent
`@tanstack/query-async-storage-persister`	5.104.5 → 5.104.6	Dependent
`@tanstack/query-broadcast-client-experimental`	5.104.5 → 5.104.6	Dependent
`@tanstack/query-core`	5.104.5 → 5.104.6	Dependent
`@tanstack/query-devtools`	5.104.5 → 5.104.6	Dependent
`@tanstack/query-persist-client-core`	5.104.5 → 5.104.6	Dependent
`@tanstack/query-sync-storage-persister`	5.104.5 → 5.104.6	Dependent
`@tanstack/react-query`	5.104.5 → 5.104.6	Dependent
`@tanstack/react-query-devtools`	5.104.5 → 5.104.6	Dependent
`@tanstack/react-query-next-experimental`	5.104.5 → 5.104.6	Dependent
`@tanstack/react-query-persist-client`	5.104.5 → 5.104.6	Dependent
`@tanstack/solid-query`	5.104.5 → 5.104.6	Dependent
`@tanstack/solid-query-devtools`	5.104.5 → 5.104.6	Dependent
`@tanstack/solid-query-persist-client`	5.104.5 → 5.104.6	Dependent
`@tanstack/svelte-query`	6.3.5 → 6.3.6	Dependent
`@tanstack/svelte-query-devtools`	6.3.5 → 6.3.6	Dependent
`@tanstack/svelte-query-persist-client`	6.3.5 → 6.3.6	Dependent
`@tanstack/vue-query-devtools`	6.3.5 → 6.3.6	Dependent

coderabbitai · 2026-10-23T16:44:44Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: test/solid-query-use-infinite-query-skiptoken-timer
File: .coderabbit.yaml
Commit: 7a54e8c
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: c94ad0e8-7a9d-472a-b6a7-3a3f10310554

📥 Commits

Reviewing files that changed from the base of the PR and between 4ed6095 and 7a54e8c.

📒 Files selected for processing: 1

packages/solid-query/src/__tests__/useInfiniteQuery.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The skipToken test in useInfiniteQuery.test.tsx changes two fake-timer advances from 11 ms to 10 ms.

Changes: Infinite query test timing

Layer / File(s)	Summary
Update skipToken timer assertions `packages/solid-query/src/__tests__/useInfiniteQuery.test.tsx`	The test advances fake timers by 10 ms before checking that the query function has not run and after setting `postId`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: tkdodo

Merge Risk: ⚪ Minimal · up to 7a54e

No merge-blocking risk is identified in this test-only timing change.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title names the package and test area (solid-query, useInfiniteQuery, skipToken test) and the specific change (aligning timer advances to the queryFn's 10ms sleep). It matches the changeset, which…
Description check		The description follows the template. It has a Changes section that explains the change (both advanceTimersByTimeAsync(11) calls become 10, matching the queryFn sleep(10)), and it gives the motivation…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the package and test area (solid-query, useInfiniteQuery, skipToken test) and the specific change (aligning timer advances to the queryFn's 10ms sleep). It matches the changeset, which changes two advanceTimersByTimeAsync calls from 11 to 10. It is a test-only change, so the 'test(...)' prefix fits. The title is long at 108 characters, but it is still specific and accurate.

Full details: Description check

Explanation

The description follows the template. It has a Changes section that explains the change (both advanceTimersByTimeAsync(11) calls become 10, matching the queryFn sleep(10)), and it gives the motivation (solid-query applies the result directly, and 9 causes a failure). All three checklist items are checked. The Release Impact section marks the change as docs/CI/dev-only, which fits a test-only edit. The changeset box is unchecked, which is correct for this case.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-23T16:46:00Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12305

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12305

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12305

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12305

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12305

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12305

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12305

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12305

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12305

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12305

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12305

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12305

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12305

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12305

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12305

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12305

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12305

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12305

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12305

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12305

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12305

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12305

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12305

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12305

commit: 7a54e8c

github-actions · 2026-10-23T16:46:14Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

test(solid-query/useInfiniteQuery): match the 'skipToken' test timer …

7a54e8c

…advances to the 'queryFn' sleep of 10ms

sukvvon self-assigned this Oct 23, 2026

sukvvon merged commit e1547fd into main Oct 23, 2026
9 checks passed

sukvvon deleted the test/solid-query-use-infinite-query-skiptoken-timer branch October 23, 2026 16:49

Navigation Menu

Repository navigation

test(solid-query/useInfiniteQuery): match the 'skipToken' test timer advances to the 'queryFn' sleep of 10ms - #12305

test(solid-query/useInfiniteQuery): match the 'skipToken' test timer advances to the 'queryFn' sleep of 10ms#12305
sukvvon merged 1 commit into
mainfrom
test/solid-query-use-infinite-query-skiptoken-timer

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 23, 2026

Uh oh!

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 23, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading