Skip to content

test(svelte-query-devtools): extract shared test setup into 'beforeEach' - #12306

Merged
sukvvon merged 1 commit into
mainfrom
test/svelte-query-devtools-shared-setup
Oct 23, 2026
Merged

sukvvon merged 1 commit into
mainfrom
test/svelte-query-devtools-shared-setup

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 23, 2026

Copy link
Copy Markdown
Member

🎯 Changes

In Devtools.svelte.test.ts, move the new QueryClient() repeated in each test into a shared beforeEach, matching the setup of the other devtools adapter tests.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@sukvvon sukvvon self-assigned this Oct 23, 2026
@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 993a66e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 993a66e

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 49s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 16:51:46 UTC

@sukvvon
sukvvon merged commit bdd5031 into main Oct 23, 2026
7 of 8 checks passed
@sukvvon
sukvvon deleted the test/svelte-query-devtools-shared-setup branch October 23, 2026 16:49
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

1 package(s) bumped directly, 23 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/vue-query 5.104.5 → 5.104.6 Changeset
@tanstack/angular-query-experimental 5.104.5 → 5.104.6 Dependent
@tanstack/eslint-plugin-query 5.104.5 → 5.104.6 Dependent
@tanstack/lit-query 0.2.30 → 0.2.31 Dependent
@tanstack/preact-query 5.104.5 → 5.104.6 Dependent
@tanstack/preact-query-devtools 5.104.5 → 5.104.6 Dependent
@tanstack/preact-query-persist-client 5.104.5 → 5.104.6 Dependent
@tanstack/query-async-storage-persister 5.104.5 → 5.104.6 Dependent
@tanstack/query-broadcast-client-experimental 5.104.5 → 5.104.6 Dependent
@tanstack/query-core 5.104.5 → 5.104.6 Dependent
@tanstack/query-devtools 5.104.5 → 5.104.6 Dependent
@tanstack/query-persist-client-core 5.104.5 → 5.104.6 Dependent
@tanstack/query-sync-storage-persister 5.104.5 → 5.104.6 Dependent
@tanstack/react-query 5.104.5 → 5.104.6 Dependent
@tanstack/react-query-devtools 5.104.5 → 5.104.6 Dependent
@tanstack/react-query-next-experimental 5.104.5 → 5.104.6 Dependent
@tanstack/react-query-persist-client 5.104.5 → 5.104.6 Dependent
@tanstack/solid-query 5.104.5 → 5.104.6 Dependent
@tanstack/solid-query-devtools 5.104.5 → 5.104.6 Dependent
@tanstack/solid-query-persist-client 5.104.5 → 5.104.6 Dependent
@tanstack/svelte-query 6.3.5 → 6.3.6 Dependent
@tanstack/svelte-query-devtools 6.3.5 → 6.3.6 Dependent
@tanstack/svelte-query-persist-client 6.3.5 → 6.3.6 Dependent
@tanstack/vue-query-devtools 6.3.5 → 6.3.6 Dependent

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 4ed6095 and 993a66e.

📒 Files selected for processing: 1
  • packages/svelte-query-devtools/tests/Devtools.svelte.test.ts
+----------------------------------------------------+
| Your logging is so chatty it needs a podcast deal. |
+----------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.76 KB (0%)
react minimal 8.59 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant