Repository navigation
Add semantic breadcrumbs to chart collections - #1466
Conversation
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 910cee7 | Commit Preview URL Branch Preview URL |
Nov 01 2026, 02:38 AM |
…n-breadcrumbs # Conflicts: # src/components/charts/ChartsCatalogPages.tsx # src/utils/chart-breadcrumbs.ts # tests/chart-breadcrumbs.test.ts
Collection pages now show Catalog / collection name as a semantic breadcrumb trail, with matching canonical BreadcrumbList data. This replaces the existing All examples link and preserves its search parameters and disabled preloading.
Continues #1151, building on merged #1465. This covers collection pages only, leaving the catalog root, library landing pages and docs for separate work.
Validation: full pnpm test through normal commit hooks, shared-component Router SSR, canonical hierarchy assertions, and a 375px isolated keyboard check returning to Catalog with theme=dark. The isolated fixture uses fallback fonts. The deployed collection preview also passed desktop/mobile layout, canonical SSR and keyboard navigation checks. The integration merge adds only the already-verified partner page changes, leaving the chart preview files identical. Google Rich Results testing of the collection page remains pending.