Skip to content

Commit

Permalink
Merge pull request #984 from glensc/git-trakt
Browse files Browse the repository at this point in the history
  • Loading branch information
glensc authored Oct 23, 2022
2 parents 55a2fef + a28fa88 commit a40930e
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,13 @@ pipenv run plextraktsync

[pipenv]: https://pipenv.pypa.io/

## Updating trakt dependency

1. Update version in `trakt/__init__py`, commit, push it
1. Add git tag, push it
1. Run `pipenv install "trakt@https://github.com/glensc/python-trakt/archive/refs/tags/3.4.1.zip#egg=trakt"`
1. Update trakt version manually in `requirements.txt`, `pipenv lock --requirements` loses the `trakt@` prefix

## Testing

We use [pytest] for testing.
Expand Down
2 changes: 1 addition & 1 deletion Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ requests = ">=2.25.1"
requests-cache = "==0.9.6"
rich = "==12.6.0"
tqdm = "==4.64.1"
trakt = "==3.4.0"
urllib3 = ">=1.26.6"
websocket-client = "==1.4.1"
trakt = {file = "https://github.com/glensc/python-trakt/archive/refs/tags/3.4.0.zip"}

[requires]
python_version = "3"
Expand Down
8 changes: 2 additions & 6 deletions Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ click==8.1.3
commonmark==0.9.1
deprecated==1.2.13
exceptiongroup==1.0.0rc9; python_version < '3.11'
trakt @ https://github.com/glensc/python-trakt/archive/refs/tags/3.4.0.zip#egg=trakt
idna==3.4; python_version >= '3.5'
inquirerpy==0.3.4
oauthlib==3.2.2; python_version >= '3.6'
Expand All @@ -31,7 +32,6 @@ requests==2.28.1
rich==12.6.0
six==1.16.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'
tqdm==4.64.1
trakt==3.4.0
url-normalize==1.4.3; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4, 3.5'
urllib3==1.26.12
wcwidth==0.2.5
Expand Down

0 comments on commit a40930e

Please sign in to comment.