Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated slide class of banner section #601

Closed
wants to merge 7 commits into from

Conversation

aakanshimalik
Copy link

#526
Description
Updated background image as originally it was not fitting the background and also not looking good . Also i have shifted h1 , p , button to the left.

Type of issue

  • Enhancement

Screenshot of output
image

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trend-trove-ecommerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:34am

Copy link
Collaborator

@hars-21 hars-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't Change the image. Only fix the overlapping text and handle responsiveness.

@Tejashri-Taral
Copy link
Owner

Any updates or should I close the PR?

@aakanshimalik
Copy link
Author

image

Now the text is not overlapping with the image .

Copy link
Owner

@Tejashri-Taral Tejashri-Taral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not looking good make it attractive

@aakanshimalik
Copy link
Author

@Tejashri-Taral What change do you prefer?..plz explain a little

@Tejashri-Taral
Copy link
Owner

Currently, you just made the colour of the banner dull(like grey) but it was originally white + you have shifted the Heading to the left which was at the center.

Also, we don't require these changes in the banner, so to give you the points as a beginner contributor I am adding 2 simple tasks to you, you can make a new PR (by pulling the latest changes first)

  1. reduce the width of vertical scrollbar width as currently it is too thick.
  2. The scrollprogress bar was present but currently it is not present, so you can make it present there again.

@Tejashri-Taral
Copy link
Owner

let me know if you can do it, otherwise we need to close the PR

@aakanshimalik aakanshimalik removed their assignment Oct 25, 2024
@hars-21 hars-21 added wontfix This will not be worked on and removed gssoc-ext hacktoberfest-accepted labels Oct 25, 2024
@hars-21 hars-21 closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants