-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated slide class of banner section #601
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't Change the image. Only fix the overlapping text and handle responsiveness.
Any updates or should I close the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not looking good make it attractive
@Tejashri-Taral What change do you prefer?..plz explain a little |
Currently, you just made the colour of the banner dull(like grey) but it was originally white + you have shifted the Heading to the left which was at the center. Also, we don't require these changes in the banner, so to give you the points as a beginner contributor I am adding 2 simple tasks to you, you can make a new PR (by pulling the latest changes first)
|
let me know if you can do it, otherwise we need to close the PR |
#526
Description
Updated background image as originally it was not fitting the background and also not looking good . Also i have shifted h1 , p , button to the left.
Type of issue
Screenshot of output