Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified %ssl_virtualhost_ip% to %hostname(fqdn)% #461

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Modified %ssl_virtualhost_ip% to %hostname(fqdn)% #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/apache.vhost-ssl.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## This configuration file assumes that mod_ssl package is installed on
## RHEL/CentOS hosts and it's configuration has not been modified.

<VirtualHost %ssl_virtualhost_ip%:443>
<VirtualHost _default_:443>
# Adjust the ServerName directive to reflect the FQDN for your host. Add
# additional ServerAlias directives if required.
ServerName tendrl
Expand Down
2 changes: 1 addition & 1 deletion config/apache.vhost.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#
# IMPORTANT: Be sure to comment out the DocumentRoot, ProxyPass and
# ProxyPassReverse directives above.
#Redirect permanent / https://%ssl_virtualhost_ip%/
#Redirect permanent / https://%ssl_virtualhost_fqdn%/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here i agree with @dahorak, it is better we use a similar kind of name everywhere align the names, So I have used %ssl_virtualhost_fqdn% instead of %hostname(fqdn)%


# The requests to /grafana will be forwarded to grafana server
ProxyPass /grafana http://127.0.0.1:3000
Expand Down