Backport bundle fix from 1.21.2 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just discovered a problem that I should've picked up before merging, in 1.21 bundles use RMB to pickup so the 1.21.2 fix actually breaks sorting on 1.21. |
|
I think the most reasonable fix will be to add a config option to allow switching between RMB (1.21) and LMB (1.21.2) behavior. |
|
i haven't had any issues with it, but if you're experiencing them in testing then yeah that seems like the most reasonable fix |
|
Did you test on 1.21 singleplayer? |
|
apologies for never responding, it's been a whirlwind couple of weeks for me. i only just tested it, and sure enough, it was still broken. looks like your changes fixed it, though, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i backported the bundle workaround from 1.21.2 to 1.21, as some other mods i'm using don't play nice with 1.21.2-3 yet and the server i'm playing on has the bundle datapack enabled. decided to put in a pull request in case anyone else is in a similar situation and wants to use it.