jshintrc: set esversion to 11 #7422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebStorm interprets the existence of .jshintrc as an intention to use JSHint, and therefore gives warnings about syntax that is not supported by the language version used in the repository. Set the version to 11 which is the highest version documented at: https://jshint.com/docs/options/#esversion so JSHint stops complaining about various things that seem to work in CI. Setting the esversion gives a complaint that esnext is incompatible with esversion. The esnext option is deprecated according to https://jshint.com/docs/options/#esnext so remove it.
pjonsson
force-pushed
the
jshint-esversion
branch
from
69cb4ad to
85d5c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
WebStorm interprets the existence
of .jshintrc as an intention to use
JSHint, and therefore gives warnings
about syntax that is not supported by
the language version used in
the repository.
Set the version to 11 which is
the highest version documented at:
https://jshint.com/docs/options/#esversion
so JSHint stops complaining about
various things that seem to work
in CI.
Setting the esversion gives a complaint
that esnext is incompatible with esversion.
The esnext option is deprecated according to
https://jshint.com/docs/options/#esnext
so remove it.
Test me
Start WebStorm and press the problems tab, and then analyze the project for errors before/after this change. Notice the number of issues in the JSHint category have decreased after.
Checklist
doc/.