TSify test/Core #7428
Open
TSify test/Core #7428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
force-pushed
the
tsify-test-core
branch
from
61a6060 to
c49bf3e
Compare
pjonsson
commented
Dec 29, 2024
| @@ -21,7 +21,7 @@ export default class CorsProxy { | |||
| * Domains that should be proxied for, as set by config files. Stored as an array of hosts - if a TLD is specified, | |||
| * subdomains will also be proxied. | |||
| */ | |||
| proxyDomains: string[] | undefined = undefined; | |||
| proxyDomains: string[] = []; | |||
There was a problem hiding this comment.
CorsProxySpec could be used almost without modifications by initializing proxyDomains to the empty array instead of undefined.
Allowing proxyDomains to be undefined means we have to insert a bunch of if (isDefined(corsProxy.proxyDomain)) { } around the content of the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
TSify test/Core.
Test me
Review the CorsProxy change, and see that the CI passes.
Checklist
doc/.