Raise RemoteInitiatedServerError on expired session key (PP-996) #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1700 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 245 245
Lines 28199 28199
Branches 6447 6447
=======================================
Hits 25440 25440
Misses 1823 1823
Partials 936 936
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonathangreen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When doing a Findaway fulfillment from B&T, we now check if
FNDSessionKeyis set toExpiredand raise aRemoteInitiatedServerErrorif that is the case.The
debug_infoincluded with this problem_detail gives the response details they want when troubleshooting these messages, so its easier to resolve them in the future.JIRA: PP-996
Motivation and Context
This appears to be a re-occurring problem, and B&T isn't putting a systematic fix in place, instead they are fixing individual accounts when we make support requests. So we want to make it easier to get this information, and to track in our logs when this is happening.
How Has This Been Tested?
Checklist