Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classes to use LoggerMixin #1838

Merged
merged 1 commit into from
May 13, 2024
Merged

Update classes to use LoggerMixin #1838

merged 1 commit into from
May 13, 2024

Conversation

jonathangreen
Copy link
Member

Description

Update a few classes to use LoggerMixin, so we get logger names that are formatted consistently.

Motivation and Context

While working on PP-1225, I needed to enable and disable some loggers at debug log level, and these inconsistently named logging classes were causing me some issues.

How Has This Been Tested?

  • Running locally

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team May 10, 2024 17:12
@jonathangreen jonathangreen mentioned this pull request May 10, 2024
2 tasks
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 90.10%. Comparing base (7f01ee6) to head (b9ceba8).
Report is 1 commits behind head on main.

Files Patch % Lines
src/palace/manager/sqlalchemy/model/work.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
- Coverage   90.10%   90.10%   -0.01%     
==========================================
  Files         299      299              
  Lines       39530    39519      -11     
  Branches     8585     8583       -2     
==========================================
- Hits        35619    35609      -10     
+ Misses       2590     2589       -1     
  Partials     1321     1321              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🪵

@jonathangreen jonathangreen merged commit 3fbf50c into main May 13, 2024
19 of 20 checks passed
@jonathangreen jonathangreen deleted the feature/logger-mixin branch May 13, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants