Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor s3 multipart uploads (PP-1472) #1995

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

jonathangreen
Copy link
Member

Description

Refactor multipart s3 uploads, so that the context manager is just a wrapper around logic in the main S3Service class.

Motivation and Context

In PP-1472, I need to do multipart s3 uploads outside of a context manager. The way this functionality was previously implemented this was impossible. This PR just moves the logic around so the functions are accessible outside of a context manager.

How Has This Been Tested?

  • Running units tests

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team August 19, 2024 23:40
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.63%. Comparing base (f04138e) to head (bb60469).
Report is 6 commits behind head on main.

Files Patch % Lines
src/palace/manager/service/storage/s3.py 94.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1995      +/-   ##
==========================================
- Coverage   90.63%   90.63%   -0.01%     
==========================================
  Files         339      339              
  Lines       40191    40201      +10     
  Branches     8695     8695              
==========================================
+ Hits        36427    36435       +8     
- Misses       2492     2493       +1     
- Partials     1272     1273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@jonathangreen jonathangreen merged commit eb2dc69 into main Aug 20, 2024
20 checks passed
@jonathangreen jonathangreen deleted the feature/refactor-s3-upload branch August 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants