Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using flask-pydantic-spec. (PP-1656) #2014

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Aug 28, 2024

Description

Stop using flask-pydantic-spec.

Motivation and Context

The flask-pydantic-spec package does not appear to be actively maintained and it is blocking an upgrade to Pydantic V2.

[Jira PP-1656]

How Has This Been Tested?

Checklist

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.59%. Comparing base (4456985) to head (100017d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/palace/manager/util/flask_util.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
- Coverage   90.63%   90.59%   -0.04%     
==========================================
  Files         339      338       -1     
  Lines       40210    40135      -75     
  Branches     8702     8681      -21     
==========================================
- Hits        36443    36361      -82     
- Misses       2494     2508      +14     
+ Partials     1273     1266       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdilauro tdilauro requested a review from a team August 28, 2024 17:50
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks good!

@tdilauro tdilauro merged commit 85f6d58 into main Aug 30, 2024
19 of 20 checks passed
@tdilauro tdilauro deleted the chore/stop-using-flask-pydantic-spec branch August 30, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants