Fix non-canonical protocol not showing settings (PP-1472) #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to show up for existing protocols.
jonathangreen
force-pushed
the
bugfix/integration-settings
branch
from
877995b to
871cb3c
Compare
jonathangreen
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2029 +/- ##
==========================================
+ Coverage 90.69% 90.70% +0.01%
==========================================
Files 342 342
Lines 40559 40579 +20
Branches 8793 8799 +6
==========================================
+ Hits 36783 36808 +25
+ Misses 2511 2508 -3
+ Partials 1265 1263 -2 ☔ View full report in Codecov by Sentry. |
tdilauro
approved these changes
Sep 5, 2024
| @@ -100,7 +101,7 @@ def test_registry_get_returns_default_if_name_not_registered( | |||
| assert registry.get("test_class", "default") == "default" | |||
|
|
|||
| # __get__ throws KeyError | |||
| with pytest.raises(KeyError): | |||
| with pytest.raises(LookupException): | |||
There was a problem hiding this comment.
Minor: ^ Want to adjust comment above?
There was a problem hiding this comment.
Missed that one 🤦🏻, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a setting is stored in the database with a non-canonical protocol, that is the protocol that is being sent to the admin UI. Because of this the admin UI isn't showing settings for these integrations.
This is a good thing to fix anyway, since its the first time we've tried migrating the name of a protocol, but it likely won't be the last time we have to migrate a protocol name.
Motivation and Context
In #2017, I updated the protocol for the MARC integration from
MARCExportertoMarcExporter. This triggered the problem on the dev server.How Has This Been Tested?
Checklist