Update Enki non-DRM to use RedirectFulfillment #2036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #2035 I noticed that we appear to be streaming full Enki ebooks though the CM, which isn't ideal. This updates to use a redirect fulfillment.
🚨
From what I see this should work, but I need to find a way to do a real world test on this. Going to leave this in draft until I figure that bit out.Edit: I did some testing with this, it does look like we are currently proxying these titles though the CM. Its not a huge number of titles, but we are better off using a redirect for them. All the local testing I can do says this should work, but can't fully test until its deployed somewhere and we can pull in a title with the mobile app.
I think this one can get merged, and we'll do some testing on minotaur then roll back if we need to.
I was testing with the title: "All I Really Need to Know I Learned from KISS" by Chris Epting.
Motivation and Context
Looks like this code came in way back as part of this PR: NYPL-Simplified/circulation#717. Looks like it was a band-aid fix that lasted ~7 years, so pretty good bandaid actually 😆.
How Has This Been Tested?
Checklist