JSONFormatter use getfqdn

[jonathangreen]

Description

Use getfqdn always, since it falls back to gethostname.

See python docs:

Return a fully qualified domain name for name. If name is omitted or empty, it is interpreted as the local host. ... In case no fully qualified domain name is available and name was provided, it is returned unchanged. If name was empty or equal to '0.0.0.0', the hostname from gethostname() is returned.

Motivation and Context

This constantly causes noise in the coverage of our test runs, because sometimes this if is hit and sometimes it isn't. Depending on the CI workers the tests run on.

How Has This Been Tested?

• Tested that this makes no difference in our production environment. Both getfqdn and gethostname always return the same thing.

Checklist

• I have updated the documentation accordingly.
• All new and existing tests passed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (f8440a8) to head (e6c621d).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2038   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files         342      342           
  Lines       40572    40568    -4     
  Branches     8796     8795    -1     
=======================================
- Hits        36808    36805    -3     
  Misses       2503     2503           
+ Partials     1261     1260    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tdilauro]

👍🏽