[PP-1686] Add test that ensures null loan end dates are included in l… #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 342 342
Lines 40514 40514
Branches 8770 8770
=======================================
Hits 36773 36773
Misses 2485 2485
Partials 1256 1256 ☔ View full report in Codecov by Sentry. |
…oan resolution query.
dbernstein
force-pushed
the
ensure-open-loans-are-resolved-properly-in-playtime-entries
branch
from
73c4f06 to
90a32a9
Compare
dbernstein
deleted the
ensure-open-loans-are-resolved-properly-in-playtime-entries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oan resolution query.
Description
In QA'ing PP-1456 I noticed we were not resolving loans with an unspecified end date where we should have been.
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1686
How Has This Been Tested?
I added a unit test to verify this case.
Checklist