Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail to location restriction self-test errors. (PP-1557) #2042

Closed
wants to merge 1 commit into from

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Sep 9, 2024

Description

Adds addition debug detail to self-tests when a location restriction mismatch occurs.

Motivation and Context

Make it easier to debug these mismatches.

[Jira PP-1557]

How Has This Been Tested?

Checklist

  • N/A I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (81b7ce9) to head (6b2380b).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/palace/manager/api/authentication/basic.py 58.33% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
- Coverage   90.76%   90.75%   -0.01%     
==========================================
  Files         342      342              
  Lines       40514    40526      +12     
  Branches     8770     8771       +1     
==========================================
+ Hits        36773    36780       +7     
- Misses       2485     2489       +4     
- Partials     1256     1257       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdilauro tdilauro requested a review from a team September 9, 2024 17:09
@tdilauro tdilauro marked this pull request as draft September 10, 2024 14:35
@tdilauro tdilauro removed the request for review from a team September 10, 2024 22:25
@tdilauro
Copy link
Contributor Author

I have a better approach to location restriction in #2049 and it includes these and other self-test detail improvements. I'm going to keep this one in draft status, but expect to eventually close it if/when the other PR is merged.

@tdilauro
Copy link
Contributor Author

Closing this one, since it is superseded by work on PR #2049 for PP-1648.

@tdilauro tdilauro closed this Sep 17, 2024
@jonathangreen jonathangreen deleted the feature/more-location-error-details branch October 16, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant