Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user agent to logs #2048

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add user agent to logs #2048

merged 1 commit into from
Sep 11, 2024

Conversation

jonathangreen
Copy link
Member

Description

If we are logging in the context of a flask request, include the user agent in the logs.

Motivation and Context

When troubleshooting with the logs, there has been a couple times where it would have been helpful to know what user agent triggered a particular log line.

How Has This Been Tested?

  • Added unit test

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen added the feature New feature label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (b136123) to head (5d551c5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2048   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files         342      342           
  Lines       40513    40515    +2     
  Branches     8770     8771    +1     
=======================================
+ Hits        36774    36776    +2     
  Misses       2484     2484           
  Partials     1255     1255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen requested a review from a team September 10, 2024 18:13
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📓 🎸

@jonathangreen jonathangreen merged commit 49c534b into main Sep 11, 2024
20 checks passed
@jonathangreen jonathangreen deleted the feature/log-user-agent branch September 11, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants