Ensures that the overdrive new titles script does not fail when cover… #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2050 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 343 343
Lines 40561 40562 +1
Branches 8787 8787
=======================================
+ Hits 36824 36825 +1
Misses 2483 2483
Partials 1254 1254 ☔ View full report in Codecov by Sentry. |
tdilauro
approved these changes
Sep 11, 2024
Comment on lines
-549
to
-551
| # finalize_batch() was called. | ||
| assert True == success_provider.finalized | ||
|
|
There was a problem hiding this comment.
Seems like we would want to ensure that finalize_batch is called, since, in hindsight, it was easy to miss. Could you make a test that fails without the fixes you made above, but passes with them?
…age records are added.
…ted and not being called when it is unexpected.
dbernstein
force-pushed
the
fix-overdrive-new-titles
branch
from
21a5bb1 to
89ec3d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…age records are added.
Description
The overdrive new titles and overdrive recent titles monitors are currently broken due to a hidden commit when coverage records are added. I discovered this issue while fixing #2040
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1708
How Has This Been Tested?
I tested this manually to make sure that it is fixed and changed a single unit test that was affected.
Checklist