Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODL feed error when license already checked out (PP-1716) #2069

Merged
merged 1 commit into from
Sep 17, 2024
Merged

ODL feed error when license already checked out (PP-1716) #2069

merged 1 commit into from
Sep 17, 2024

Conversation

jonathangreen
Copy link
Member

Description

In #2057 I partially solved this one. We are doing the correct thing raising NoAvailableCopies. But then when we try to place a hold, because we didn't update the availability, the we were raising CurrentlyAvailable.

Motivation and Context

JIRA: PP-1716

How Has This Been Tested?

  • Unit tests

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen changed the title Fix error in license accounting when license already checked out (PP-1716) ODL feed error when license already checked out (PP-1716) Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (a18d4d8) to head (d3eb923).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2069      +/-   ##
==========================================
+ Coverage   90.70%   90.79%   +0.09%     
==========================================
  Files         344      344              
  Lines       40610    40612       +2     
  Branches     8793     8793              
==========================================
+ Hits        36835    36874      +39     
+ Misses       2504     2484      -20     
+ Partials     1271     1254      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen requested a review from a team September 17, 2024 18:33
tdilauro
tdilauro approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🏁

@jonathangreen jonathangreen merged commit 175bbc5 into main Sep 17, 2024
21 checks passed
@jonathangreen jonathangreen deleted the bugfix/odl-already-checked-out branch September 17, 2024 20:34
jonathangreen added a commit that referenced this pull request Sep 18, 2024
@jonathangreen
Fix error in license accounting when license already checked out. (#2069
998f0f9 
)
@jonathangreen jonathangreen added the bug Something isn't working label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdilauro tdilauro tdilauro approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathangreen @tdilauro