Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag for quicksight. (PP-1724) #2071

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Sep 18, 2024

Description

Adds a feature flag to suppress QuickSight link for non-sysadmins from the Admin UI dashboard statistics page.

Motivation and Context

Need to be able to hide QuickSight dashboard until it is ready to launch.

[Jira PP-1724]

How Has This Been Tested?

Checklist

  • N/A I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (a18d4d8) to head (10da73b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
+ Coverage   90.70%   90.79%   +0.09%     
==========================================
  Files         344      344              
  Lines       40610    40613       +3     
  Branches     8793     8793              
==========================================
+ Hits        36835    36875      +40     
+ Misses       2504     2484      -20     
+ Partials     1271     1254      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tdilauro tdilauro merged commit ea0a669 into main Sep 18, 2024
20 checks passed
@tdilauro tdilauro deleted the feature/admin-ui-quicksight-feature-flag branch September 18, 2024 12:40
jonathangreen pushed a commit that referenced this pull request Sep 18, 2024
@jonathangreen jonathangreen added the feature New feature label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants