More realistic MockSessionMaker

[jonathangreen]

Description

Updates the behavior of MockSessionMaker.__call__ to more accurately reflect what a real session maker object does.

Motivation and Context

Within a Celery task if you do:

with task.session() as session:
   ...

It will automatically open and close the session for you, but you are on your own to remember to commit if you need to. Previously this data was still available after the fixture ran, so it looked to tests like it was committed. However now it won't be unless its explicitly committed, which is more accurate and should help catch mistakes.

How Has This Been Tested?

• Tested in CI

Checklist

• I have updated the documentation accordingly.
• All new and existing tests passed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (e54575f) to head (819da61).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2104   +/-   ##
=======================================
  Coverage   90.65%   90.65%           
=======================================
  Files         344      344           
  Lines       40581    40581           
  Branches     8822     8822           
=======================================
  Hits        36790    36790           
  Misses       2484     2484           
  Partials     1307     1307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tdilauro]

🟰