Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert rotate jwe key script into a celery task (PP-1480) #2253

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

jonathangreen
Copy link
Member

Description

Convert token rotation script to celery task.

Motivation and Context

JIRA: PP-1480

Part of the epic to convert all our scripts to be celery tasks: PP-107

How Has This Been Tested?

  • Running unit tests

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team January 16, 2025 15:26
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (17948cb) to head (166528d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2253   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         363      363           
  Lines       41297    41299    +2     
  Branches     8841     8843    +2     
=======================================
+ Hits        37629    37631    +2     
  Misses       2406     2406           
  Partials     1262     1262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jonathangreen jonathangreen merged commit c8804c5 into main Jan 17, 2025
21 checks passed
@jonathangreen jonathangreen deleted the chore/celery-token-rotate-script branch January 17, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants